xorca_brokenline issueshttps://git.geomar.de/python/xorca_brokenline/-/issues2023-10-02T10:05:28Zhttps://git.geomar.de/python/xorca_brokenline/-/issues/25Incompatible with newer Xarray2023-10-02T10:05:28ZWilli RathIncompatible with newer XarrayXarray deleted their `ufuncs` submodule, we need to use `np` ufuncs in future versions.Xarray deleted their `ufuncs` submodule, we need to use `np` ufuncs in future versions.https://git.geomar.de/python/xorca_brokenline/-/issues/24additional variables/attributes to be stored in section or transport dataset2021-05-07T06:13:49ZKlaus Getzlaffadditional variables/attributes to be stored in section or transport datasetmore a note than an issue...
just thinking about what else should be implemented to be extracted from the "original" data?
This is easy to select within function `shift_grids` by adding them into optional argument
`vars_to_keep=('...more a note than an issue...
just thinking about what else should be implemented to be extracted from the "original" data?
This is easy to select within function `shift_grids` by adding them into optional argument
`vars_to_keep=('vozocrtx', 'vomecrty', 'votemper', 'vosaline', 'vosigma0')`
I would recommend to include the following variables:
* [ ] `sossheig` : necessary to include in freshwater/heat computations
* [ ] `somixhgt` : interesting to have for quick mixed-layer depth visualization along the section
* [X] include some attributes to the variables like 'units' and for freshwater computation also the 'reference salinity' used (this fits into the function `calculate_transport`)https://git.geomar.de/python/xorca_brokenline/-/issues/23needs xarray version >= v0.112019-05-09T11:04:33ZKlaus Getzlaffneeds xarray version >= v0.11running xarray_< v0.11 shows error during execution of `example_02.ipyn` calling function `select_section` while `section = section.assign({'ii': ii[:-1]})`
upgrading with `conda install xarray` solves the problemrunning xarray_< v0.11 shows error during execution of `example_02.ipyn` calling function `select_section` while `section = section.assign({'ii': ii[:-1]})`
upgrading with `conda install xarray` solves the problemhttps://git.geomar.de/python/xorca_brokenline/-/issues/22Include high-level function2019-05-02T13:21:53ZPatrick WagnerInclude high-level functionInclude a high level function that takes coordinates and input data as input and returns a section dataset.Include a high level function that takes coordinates and input data as input and returns a section dataset.https://git.geomar.de/python/xorca_brokenline/-/issues/21Memory efficiency2019-04-17T08:28:52ZPatrick WagnerMemory efficiencyThe whole script is not very memory efficient. The full datasets (U,V,T) are loaded into memory. <br>
This seems to be caused by the masking of land values with xr.where():
https://git.geomar.de/python/xorca_brokenline/blob/master/xorca_...The whole script is not very memory efficient. The full datasets (U,V,T) are loaded into memory. <br>
This seems to be caused by the masking of land values with xr.where():
https://git.geomar.de/python/xorca_brokenline/blob/master/xorca_brokenline/__init__.py#L149 <br>
A solution might be to define the mask and do the masking after the selection of the section.https://git.geomar.de/python/xorca_brokenline/-/issues/20Add rotated velocities2020-04-23T07:54:30ZPatrick WagnerAdd rotated velocitiesRotate the velocities at each point to give velocities normal to each section leg. <br>
The required velocity along each section segment is already provided by https://git.geomar.de/python/xorca_brokenline/merge_requests/23. <br>Rotate the velocities at each point to give velocities normal to each section leg. <br>
The required velocity along each section segment is already provided by https://git.geomar.de/python/xorca_brokenline/merge_requests/23. <br>https://git.geomar.de/python/xorca_brokenline/-/issues/19Aux var names are untested2019-04-15T14:21:02ZWilli RathAux var names are untested!21 is not tested.!21 is not tested.https://git.geomar.de/python/xorca_brokenline/-/issues/18Volume weighted tracer interpolation2022-01-03T10:36:50ZPatrick WagnerVolume weighted tracer interpolationhttps://git.geomar.de/python/xorca_brokenline/-/issues/17Coordinate and grid scale variables have spurious time dimension2019-04-16T15:41:47ZPatrick WagnerCoordinate and grid scale variables have spurious time dimensionhttps://git.geomar.de/python/xorca_brokenline/-/issues/16Add coordinates to section2019-04-16T14:10:10ZPatrick WagnerAdd coordinates to sectionhttps://git.geomar.de/python/xorca_brokenline/-/issues/15Fails with different mesh and mask files2019-04-11T09:20:07ZPatrick WagnerFails with different mesh and mask filesSeveral routines fail if the provided mesh and mask files dont follow the expected layout and variable naming. <br>
The names of the variables should become an optional parameter. This would at least solve the issue for cases where the ...Several routines fail if the provided mesh and mask files dont follow the expected layout and variable naming. <br>
The names of the variables should become an optional parameter. This would at least solve the issue for cases where the "wrong" variable name causes a problem.https://git.geomar.de/python/xorca_brokenline/-/issues/14Speed up CI by using pre-built image?2019-04-05T09:56:48ZWilli RathSpeed up CI by using pre-built image?In https://git.geomar.de/python/xorca_docker, I've built a docker image that contains all we need here. This https://git.geomar.de/python/xorca_mockup_nemo_data/blob/master/.gitlab-ci.yml shows how to use this image (and drop the then-o...In https://git.geomar.de/python/xorca_docker, I've built a docker image that contains all we need here. This https://git.geomar.de/python/xorca_mockup_nemo_data/blob/master/.gitlab-ci.yml shows how to use this image (and drop the then-obsolete package installation steps).
Result will be reduced job durations because the env is not built everytime a test is run.
(cc: @jan\-klaus\-rieck)https://git.geomar.de/python/xorca_brokenline/-/issues/13Wrong interpolation2019-04-05T12:30:48ZPatrick WagnerWrong interpolationInterpolation does not account for land values. This has no effect so far because we only calculate volume transport, where no interpolated values are used. <br>
This will become relevant for the calculation of tracer transports.Interpolation does not account for land values. This has no effect so far because we only calculate volume transport, where no interpolated values are used. <br>
This will become relevant for the calculation of tracer transports.https://git.geomar.de/python/xorca_brokenline/-/issues/12Add lonlat2ij to example2019-04-16T15:15:01ZPatrick WagnerAdd lonlat2ij to examplehttps://git.geomar.de/python/xorca_lonlat2ijhttps://git.geomar.de/python/xorca_lonlat2ijhttps://git.geomar.de/python/xorca_brokenline/-/issues/11Preparing v1.0.02019-04-03T08:03:55ZWilli RathPreparing v1.0.0- [x] Examples (see also #10 and !16)
- [x] move Example to `xorca_brokenline/examples/example_01.ipynb`
- [x] update link in `README.md`
- [x] Cleanly re-run example (there's something like `In [43]` although the notebook is quite...- [x] Examples (see also #10 and !16)
- [x] move Example to `xorca_brokenline/examples/example_01.ipynb`
- [x] update link in `README.md`
- [x] Cleanly re-run example (there's something like `In [43]` although the notebook is quite short)
- [x] Add version number to `setup.py`.
- [x] Check test coverage (see #9)
- [x] Update installation instructions to use `git+https://git.geomar.de/python/xorca_brokenline.git@v1.0.0` instead of `@master`.
If everything is done, we can create a tag v1.0.0Patrick WagnerPatrick Wagnerhttps://git.geomar.de/python/xorca_brokenline/-/issues/10Make examples part of the package2019-04-03T08:05:12ZWilli RathMake examples part of the packageIf there's not too much data, I'd make the examples a part of the package.If there's not too much data, I'd make the examples a part of the package.https://git.geomar.de/python/xorca_brokenline/-/issues/9Test coverage2019-04-03T08:07:53ZWilli RathTest coverageThere's un-tested code:
1. This `if` block is never touched during tests: https://git.geomar.de/python/xorca_brokenline/blob/master/xorca_brokenline/__init__.py#L126
2. Reducing the grid never drops anything: https://git.geomar.de/pyt...There's un-tested code:
1. This `if` block is never touched during tests: https://git.geomar.de/python/xorca_brokenline/blob/master/xorca_brokenline/__init__.py#L126
2. Reducing the grid never drops anything: https://git.geomar.de/python/xorca_brokenline/blob/master/xorca_brokenline/__init__.py#L35
See coverage report at the end of the job (e.g. https://git.geomar.de/python/xorca_brokenline/-/jobs/5459) for details.https://git.geomar.de/python/xorca_brokenline/-/issues/8Include handling of subsection2019-03-28T11:37:34ZPatrick WagnerInclude handling of subsectionSo far, only a straight line between start/end points is possible. The user should be able to provide an arbitrary number of points that are then connected by straight segments. <br>
Bevor this issue is tackled we should decide on issue ...So far, only a straight line between start/end points is possible. The user should be able to provide an arbitrary number of points that are then connected by straight segments. <br>
Bevor this issue is tackled we should decide on issue https://git.geomar.de/python/xorca_brokenline/issues/4https://git.geomar.de/python/xorca_brokenline/-/issues/7Include normal and along-section velocities2019-04-16T14:09:53ZPatrick WagnerInclude normal and along-section velocitieshttps://git.geomar.de/python/xorca_brokenline/-/issues/6Include heat transport2019-09-05T12:57:32ZPatrick WagnerInclude heat transport